Skip to content

chore(NavExpandable): Change e to event in onExpand #8897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

chore(NavExpandable): Change e to event in onExpand #8897

merged 1 commit into from
Apr 5, 2023

Conversation

@jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Mar 31, 2023

What: Closes #8894

@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 31, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-8897.surge.sh

A11y report: https://patternfly-react-pr-8897-a11y.surge.sh

tlabaj
tlabaj approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs associated codemod issue if not already opened.

jenny-s51
jenny-s51 commented Apr 5, 2023
View reviewed changes
Copy link
Contributor Author

@jenny-s51 jenny-s51 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlabaj would this need a codemod if the event parameter already exists and we are just renaming it internally?

@tlabaj
Copy link
Contributor

tlabaj commented Apr 5, 2023

@tlabaj would this need a codemod if the event parameter already exists and we are just renaming it internally?

Yup. You are right!

@tlabaj tlabaj merged commit 0a3d96e into patternfly:v5 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlabaj tlabaj tlabaj approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NavExpandable: For consistency change the parameter name from e to event in onExpand

4 participants

@jenny-s51 @patternfly-build @tlabaj @kmcfaul