feat(ExpandableSection): Add event to onToggle #8991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-8991.surge.sh A11y report: https://patternfly-react-pr-8991-a11y.surge.sh |
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Could we also update the onToggle in ExpandableSectionToggle sub-component, as well as examples that use it (believe only the ExpandableSection's "Detached" example and CodeBlock's "Expandable" example)? Either that or it could be another issue for the epic.
Contributor
Author
|
I think I would prefer that to be a separate issue in the epic like most other subcomponents are, but I wouldn't say I'm dead set on that. |
thatblindgeye
approved these changes
Apr 26, 2023
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
I have no strong preference either way so a separate issue sounds good to me 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8880
Additional issues: