Skip to content

Conversation

@mcarrano
Copy link
Member

@mcarrano mcarrano commented May 2, 2023

Just changing where this shows up in the nav per this issue.

What: Closes #9026

@patternfly-build
Copy link
Contributor

patternfly-build commented May 2, 2023

@mcarrano mcarrano requested review from nicolethoen and tlabaj May 2, 2023 21:10
@mcarrano
Copy link
Member Author

mcarrano commented May 2, 2023

@nicolethoen @tlabaj I opened this PR to add the date range picker demo back to Date picker. I realized I did this too hastily as there is an additional unrelated demo there. Let me know if you have any questions. If you agree this makes sense, please go ahead and merge.

@tlabaj
Copy link
Contributor

tlabaj commented May 3, 2023

@nicolethoen @tlabaj I opened this PR to add the date range picker demo back to Date picker. I realized I did this too hastily as there is an additional unrelated demo there. Let me know if you have any questions. If you agree this makes sense, please go ahead and merge.

@mcarrano it looks like this PR just change the id if the demo.

in regards to the Date and time range picker demo, may it make sense to move it under the "Date and time picker" nav item.

@mcarrano
Copy link
Member Author

mcarrano commented May 3, 2023

@tlabaj I think that makes sense. Let me try moving that code.

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 1498423 into patternfly:v5 May 3, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-alpha.89
  • @patternfly/react-core@5.0.0-alpha.88
  • @patternfly/react-docs@6.0.0-alpha.95
  • demo-app-ts@5.0.0-alpha.72
  • @patternfly/react-integration@5.0.0-alpha.36
  • @patternfly/react-table@5.0.0-alpha.90

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Date Picker - Move Date Range picker demo back under Date Picker

4 participants