feat(Table): added class names for table elements #9133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9133.surge.sh A11y report: https://patternfly-react-pr-9133-a11y.surge.sh |
mattnolting
approved these changes
May 17, 2023
Contributor
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
Looks great, thanks @wise-king-sullyman !!! LPTM
nicolethoen
approved these changes
May 17, 2023
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Table updates look good!
wise-king-sullyman
force-pushed
the
table-selector-update
branch
from
8683818 to
19762f1
Compare
wise-king-sullyman
force-pushed
the
table-selector-update
branch
from
19762f1 to
f5c4221
Compare
thatblindgeye
approved these changes
May 18, 2023
kmcfaul
approved these changes
May 18, 2023
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
* feat(Table): added class names for table elements * chore(Table): updated snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9129
I branched off of #9132, so only the changes from d2f4887 and 8683818 should be reviewed in this PR. I'll rebase this branch again to simplify things once #9132 merges, but wanted to get this available for review now.