feat(Flex): add plain gap spacing #9143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9143.surge.sh A11y report: https://patternfly-react-pr-9143-a11y.surge.sh |
kmcfaul
force-pushed
the
flex-plain-gap
branch
2 times, most recently
from
dbbbad8 to
39cab8c
Compare
Contributor
Author
|
Waiting on #9133 to fix table |
Contributor
Author
|
Rebased |
nicolethoen
approved these changes
May 18, 2023
thatblindgeye
approved these changes
May 18, 2023
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
React-wise looks good. Not related to this PR, but I'm noticing that using gapXs doesn't seem to apply any class/do anything? Though this is present in both React and Core workspaces. @mcoker is the xs spacing for gap working as intended?
tlabaj
approved these changes
May 18, 2023
Contributor
|
@thatblindgeye nice catch! Sorry I didn't see that comment until after I reviewed - opened a core issue, it should fix the react component once merged patternfly/patternfly#5600 |
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
* feat(Flex): add plain gap spacing * update core dep * bump core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9141
Adds the plain/non-size modifiers to gap, row gap, and column gap.
Currently this will not actually apply any styling because react's core package needs a version bump.