Skip to content

Conversation

@thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented May 23, 2023

What: Related to patternfly/patternfly#5604
Closes #9170

Code to test
import React from 'react';
import { FormSelect, Select, SelectOption, SelectList, MenuToggle, MenuToggleElement, Checkbox } from '@patternfly/react-core';

export const SelectBasic: React.FunctionComponent = () => {
  const toggle = (toggleRef: React.Ref<MenuToggleElement>) => (
    <MenuToggle
      isFullWidth
    >
      Select toggle
    </MenuToggle>
  );

  return (
    <React.Fragment>
      <Select
        toggle={toggle}
        shouldFocusToggleOnSelect
      >
        <SelectList>
          <SelectOption itemId="Option 1">Option 1</SelectOption>
          <SelectOption itemId="Option 2">Option 2</SelectOption>
          <SelectOption itemId="Option 3">Option 3</SelectOption>
        </SelectList>
      </Select>
      <FormSelect value="Form select toggle" aria-label="FormSelect Input" ouiaId="BasicFormSelect">

        <FormSelectOption value="Form select toggle" label="Form select toggle" />

    </FormSelect>
    </React.Fragment>
  );
};

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented May 23, 2023

@thatblindgeye thatblindgeye force-pushed the formSelectToggleIcon branch from fd67602 to 7aa235c Compare May 23, 2023 17:52
@thatblindgeye thatblindgeye marked this pull request as ready for review May 23, 2023 17:52
@tlabaj tlabaj requested review from mcoker and srambach May 25, 2023 23:31
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L🎃TM

@tlabaj tlabaj merged commit 07c7e5a into patternfly:v5 May 26, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.0.0-alpha.121
  • @patternfly/react-core@5.0.0-alpha.120
  • @patternfly/react-docs@6.0.0-alpha.129
  • demo-app-ts@5.0.0-alpha.104
  • @patternfly/react-table@5.0.0-alpha.123

Thanks for your contribution! 🎉

nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
* fix(FormSelect): updated classname for toggle icon

* Updated snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - FormSelect - wrong class being applied to toggle

6 participants