Skip to content

fix(FormSelect): updated classname for toggle icon #9168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2023
Merged

fix(FormSelect): updated classname for toggle icon #9168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ef8418
fix(FormSelect): updated classname for toggle icon
May 23, 2023
7aa235c
Updated snapshots
May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/react-core/src/components/FormSelect/FormSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,9 @@ export class FormSelect extends React.Component<FormSelectProps, { ouiaStateId:
</select>
<div className={css(styles.formControlUtilities)}>
{hasStatusIcon && <FormControlIcon status={validated as 'success' | 'error' | 'warning'} />}
<FormControlIcon customIcon={<CaretDownIcon />} />
<div className={css(styles.formControlToggleIcon)}>
<CaretDownIcon />
</div>
</div>
</div>
);
Expand Down
18 changes: 9 additions & 9 deletions ...ges/react-core/src/components/FormSelect/__tests__/__snapshots__/FormSelect.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ exports[`FormSelect Disabled FormSelect input 1`] = `
class="pf-v5-c-form-control__utilities"
>
<div
class="pf-v5-c-form-control__icon"
class="pf-v5-c-form-control__toggle-icon"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -66,7 +66,7 @@ exports[`FormSelect FormSelect input with aria-label does not generate console e
class="pf-v5-c-form-control__utilities"
>
<div
class="pf-v5-c-form-control__icon"
class="pf-v5-c-form-control__toggle-icon"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -109,7 +109,7 @@ exports[`FormSelect FormSelect input with id does not generate console error 1`]
class="pf-v5-c-form-control__utilities"
>
<div
class="pf-v5-c-form-control__icon"
class="pf-v5-c-form-control__toggle-icon"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -150,7 +150,7 @@ exports[`FormSelect FormSelect input with no aria-label or id generates console
class="pf-v5-c-form-control__utilities"
>
<div
class="pf-v5-c-form-control__icon"
class="pf-v5-c-form-control__toggle-icon"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -238,7 +238,7 @@ exports[`FormSelect Grouped FormSelect input 1`] = `
class="pf-v5-c-form-control__utilities"
>
<div
class="pf-v5-c-form-control__icon"
class="pf-v5-c-form-control__toggle-icon"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -318,7 +318,7 @@ exports[`FormSelect Simple FormSelect input 1`] = `
class="pf-v5-c-form-control__utilities"
>
<div
class="pf-v5-c-form-control__icon"
class="pf-v5-c-form-control__toggle-icon"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -375,7 +375,7 @@ exports[`FormSelect invalid FormSelect input 1`] = `
</svg>
</div>
<div
class="pf-v5-c-form-control__icon"
class="pf-v5-c-form-control__toggle-icon"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -432,7 +432,7 @@ exports[`FormSelect validated success FormSelect input 1`] = `
</svg>
</div>
<div
class="pf-v5-c-form-control__icon"
class="pf-v5-c-form-control__toggle-icon"
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -489,7 +489,7 @@ exports[`FormSelect validated warning FormSelect input 1`] = `
</svg>
</div>
<div
class="pf-v5-c-form-control__icon"
class="pf-v5-c-form-control__toggle-icon"
>
<svg
aria-hidden="true"
Expand Down