chore(PrimaryDetail): Update demos with deprecated Select to use latest Select #9178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9178.surge.sh A11y report: https://patternfly-react-pr-9178-a11y.surge.sh |
jpuzz0
force-pushed
the
chore/update-primary-detail-demos
branch
from
2c45f89 to
d91dac8
Compare
Contributor
|
Depending on the merge order, this PR will need to update these demo with the renamed props after this merges or the updated prop name will need to be made here. |
nicolethoen
approved these changes
May 25, 2023
thatblindgeye
approved these changes
May 25, 2023
jpuzz0
force-pushed
the
chore/update-primary-detail-demos
branch
from
d91dac8 to
956295a
Compare
Contributor
Author
Rebased and updated demos accordingly since @thatblindgeye's PR just merged. |
nicolethoen
approved these changes
May 26, 2023
gitdallas
approved these changes
May 30, 2023
jpuzz0
force-pushed
the
chore/update-primary-detail-demos
branch
from
956295a to
936aa99
Compare
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
…st Select (patternfly#9178) * chore(PrimaryDetail): Update demos with deprecated Select to use latest Select * update demos with Select itemId -> value prop name change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9018
Also updated all 3 examples with deprecated Select components to use typescript, functional components, with some cleanup.