fix(ChartScatter): consider bubbleProperty if it is set #9282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bubbleProperty is only considered if the size prop is undefined, therefore set default size function only if bubbleProperty is not set. Ref. https://github.com/FormidableLabs/victory/blob/bbc1e2a39448d7fb6724f916afacf5f6eab7d1b3/packages/victory-scatter/src/helper-methods.tsx#L35-L43 Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Contributor
|
Preview: https://patternfly-react-pr-9282.surge.sh A11y report: https://patternfly-react-pr-9282-a11y.surge.sh |
iblancasa
approved these changes
Jun 26, 2023
dlabrecq
approved these changes
Aug 15, 2023
Member
|
@tlabaj Do we need an issue for this? |
Contributor
Contributor
|
@andreasgerstmayr can you please open an issue for tracking so we can merge this one. |
Contributor
Author
tlabaj
approved these changes
Aug 16, 2023
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
) bubbleProperty is only considered if the size prop is undefined, therefore set default size function only if bubbleProperty is not set. Ref. https://github.com/FormidableLabs/victory/blob/bbc1e2a39448d7fb6724f916afacf5f6eab7d1b3/packages/victory-scatter/src/helper-methods.tsx#L35-L43 Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
bubblePropertyofVictoryScatteris only considered if the size prop is undefined (see https://github.com/FormidableLabs/victory/blob/bbc1e2a39448d7fb6724f916afacf5f6eab7d1b3/packages/victory-scatter/src/helper-methods.tsx#L35-L43)This PR updates the code to set the default
sizefunction only ifbubblePropertyis not set.closes: #9504