Skip to content

fix(ChartScatter): consider bubbleProperty if it is set #9282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023
Merged

fix(ChartScatter): consider bubbleProperty if it is set #9282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/react-charts/src/components/ChartScatter/ChartScatter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,6 @@ export const ChartScatter: React.FunctionComponent<ChartScatterProps> = ({

// destructure last
theme = getTheme(themeColor),
size = ({ active }) => (active ? ChartScatterStyles.activeSize : ChartScatterStyles.size),
...rest
}: ChartScatterProps) => {
// Clone so users can override container props
Expand All @@ -455,8 +454,14 @@ export const ChartScatter: React.FunctionComponent<ChartScatterProps> = ({
...containerComponent.props
});

// bubbleProperty is only considered if the size prop is undefined, therefore set
// default size function only if bubbleProperty is not set.
if (typeof rest.size === "undefined" && typeof rest.bubbleProperty === "undefined") {
rest.size = ({ active }) => (active ? ChartScatterStyles.activeSize : ChartScatterStyles.size);
}

// Note: containerComponent is required for theme
return <VictoryScatter containerComponent={container} size={size} theme={theme} {...rest} />;
return <VictoryScatter containerComponent={container} theme={theme} {...rest} />;
};
ChartScatter.displayName = 'ChartScatter';

Expand Down