Skip to content

Conversation

@Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented Jun 22, 2023

Changes

  • change the transformer-cjs-imports to transformer-dynamic-imports

Transform dynamic imports

Transforms any relative import paths from icons of react-core packages to point to the dynamic output at build time.

// relative import path
import { Button, Tooltip } from '@patternfly/react-core'

// is split and transformed to
import { Button } from '@patternfly/react-core/dist/dynamic/components/Button'
import { Tooltip } from '@patternfly/react-core/dist/dynamic/components/Tooltip'

Transforming any dist/esm references to dist/dynamic for icons and react-core packages

cc @dlabaj @evwilkin

Ideally this transformation should happen every PF extension library as well

@evwilkin evwilkin requested a review from tlabaj June 22, 2023 11:53
@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 22, 2023

@dlabaj dlabaj self-requested a review June 23, 2023 13:15
@tlabaj tlabaj merged commit 5c2ad35 into patternfly:main Jul 10, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • transformer-dynamic-imports@4.79.4-alpha.1

Thanks for your contribution! 🎉

@Hyperkid123 Hyperkid123 deleted the update-dynamic-transform-plugin branch July 10, 2023 16:17
tlabaj added a commit that referenced this pull request Jul 14, 2023
nicolethoen pushed a commit that referenced this pull request Jul 14, 2023
nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants