Revert "fix(build): transform icons and react core dependencies imports" #9366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9366.surge.sh A11y report: https://patternfly-react-pr-9366-a11y.surge.sh |
nicolethoen
reviewed
Jul 14, 2023
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
reverting a change to a yarn.lock file seems a little weird to me. Did you happen to try running yarn install and regenerating this after you made the reversion, given the fact that a few other PRs might have touched the yarn.lock file since?
Contributor
Author
Yup. It built fine when I pulled it down. No further updates to yarn needed. |
dlabaj
approved these changes
Jul 14, 2023
nicolethoen
approved these changes
Jul 14, 2023
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
…ts (patternfly#9298)" (patternfly#9366) This reverts commit 5c2ad35.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9298