chore(a11y): clean up a11y config so we test valid URLs and limit timeouts #9328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9328.surge.sh A11y report: https://patternfly-react-pr-9328-a11y.surge.sh |
jenny-s51
approved these changes
Jul 5, 2023
Contributor
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
LGTM - a11y tests running as expected. Just wondering if we need the console.log or if it can be removed
gitdallas
approved these changes
Aug 8, 2023
kmcfaul
approved these changes
Aug 9, 2023
nicolethoen
added a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
…eouts (patternfly#9328) * chore(a11y): clean up a11y config so we test valid URLs and limit timeouts * tighten logic a little more * remove console statement * use logical OR rather than bitwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9327