Skip to content

chore(a11y): clean up a11y config so we test valid URLs and limit timeouts #9328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2023
Merged

chore(a11y): clean up a11y config so we test valid URLs and limit timeouts #9328

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b421556
chore(a11y): clean up a11y config so we test valid URLs and limit tim…
nicolethoen Jul 3, 2023
7f6c168
tighten logic a little more
nicolethoen Jul 5, 2023
bbbe5de
remove console statement
nicolethoen Jul 17, 2023
bf6c579
use logical OR rather than bitwise
nicolethoen Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/react-docs/patternfly-a11y.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,25 @@ const urls = Object.keys(fullscreenRoutes)
if (fullscreenRoutes[key].isFullscreenOnly) {
return key;
} else {
// the default tab for each component/pattern does not have a trailing 'react-demo' or 'react' string in the url
// so we strip the trailing string from those paths.
const path = fullscreenRoutes[key].path;
if (path.match(/\/demos\/.*\/react-demos$/g)) {
if (path.match(/\/patterns\/.*\/react-demos$/g)) {
return path.replace(/\/react-demos$/, '');
} else {
// some demos have been moved to the component section, so their default tab has a trailing 'react-demos'
if (path.match(/\/components\/.*\/react-demos$/g)){
if (path.includes('/application-launcher/') ||
path.includes('/context-selector/') ||
path.includes('/date-and-time-picker/') ||
path.includes('/password-generator/') ||
path.includes('/password-strength/') ||
path.includes('/custom-menus/') ||
path.includes('/options-menu/')) {
return path.replace(/\/react-demos$/, '');
}
}
// all other pages in the components section have a trailing 'react' string in their default tab
return path.replace(/\/react$/, '');
}
}
Expand Down