Convert Card View demo to TS #9359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview: https://patternfly-react-pr-9359.surge.sh A11y report: https://patternfly-react-pr-9359-a11y.surge.sh |
jenny-s51
force-pushed
the
iss9124_card-view
branch
from
7f162e2 to
758641f
Compare
kmcfaul
approved these changes
Jul 31, 2023
2 tasks
jenny-s51
force-pushed
the
iss9124_card-view
branch
2 times, most recently
from
8b6b498 to
bbe51d3
Compare
Contributor
|
Code looks good, but unless I'm misunderstanding something (not unlikely) shouldn't this update the markdown file to point to this new tsx file? |
tlabaj
requested changes
Aug 23, 2023
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
Is there additional work that is needed her? like deleting js in MD file and adding this new file?
jenny-s51
force-pushed
the
iss9124_card-view
branch
from
bbe51d3 to
91041c7
Compare
jenny-s51
commented
Aug 23, 2023
Contributor
Author
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
@wise-king-sullyman @tlabaj yes, thanks! Updated
wise-king-sullyman
approved these changes
Aug 24, 2023
Contributor
|
Looks good to me other than the docs build failing CI. |
tlabaj
reviewed
Aug 28, 2023
| export const CardViewBasic: React.FunctionComponent = () => { | ||
| const totalItemCount = 10; | ||
|
|
||
| const [cardData, setCardData] = React.useState(data); |
Contributor
There was a problem hiding this comment.
looks like you are missing the import for data
jenny-s51
force-pushed
the
iss9124_card-view
branch
from
b5b2661 to
5e00d1f
Compare
tlabaj
approved these changes
Sep 13, 2023
Contributor
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Towards #9124, Closes #9362
Additional issues: Waiting on #9322. Will rebase once #9322 is merged.