feat(DataList): added event param to callback #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitdallas
approved these changes
Mar 6, 2023
gitdallas
requested review from
gitdallas,
jenny-s51,
kmcfaul and
wise-king-sullyman
gitdallas
reviewed
Mar 6, 2023
| })), | ||
| ...onToggleAPIUpdateList.map((component) => ({ | ||
| code: `import { ${component} } from '@patternfly/react-core'; const onToggle = (isOpen) => {}; <${component} onToggle={onToggle} />;`, | ||
| output: `import { ${component} } from '@patternfly/react-core'; const onToggle = (_event, isOpen) => {}; <${component} onToggle={onToggle} />;`, |
Collaborator
Author
|
@gitdallas for now I ust copy+pasted the logic from the onToggle codemod to the DataList one. I can do something similar to my other 2 open PRs. Figure we can create a possible helper as a followup. |
gitdallas
requested changes
Mar 7, 2023
Contributor
gitdallas
left a comment
gitdallas
left a comment
There was a problem hiding this comment.
overall this is awesome, a few comments/nits
packages/eslint-plugin-pf-codemods/lib/rules/v5/dataList-updated-callback.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-pf-codemods/lib/rules/v5/dataList-updated-callback.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-pf-codemods/lib/rules/v5/onToggle-updated-paramaters.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-pf-codemods/lib/rules/v5/dataList-updated-callback.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-pf-codemods/test/rules/v5/onToggle-updated-paramaters.js
Outdated
Show resolved
Hide resolved
wise-king-sullyman
approved these changes
Mar 7, 2023
Collaborator
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
This is like magic
Collaborator
Author
|
@gitdallas @wise-king-sullyman refactored the logic in both codemods as a (currently very basic, specific) helper function. Should be a lot easier for similar codemods for adding that "event" param (or any param really, as long as its meant to be the first one). Figure this could be a building block for more flexible things down the line |
This was referenced Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #289, closes #295
The update made to SelectableRowObject in the linked PR for this codemod shouldn't be needed here, as patternfly/patternfly-react#8423 will require a codemod that will handle that.
Also made an update to the onToggle codemod similar to this.