Improvements to addCallbackParam helper & associated tests #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wise-king-sullyman
changed the title
wise-king-sullyman
changed the title
thatblindgeye
approved these changes
Mar 14, 2023
Collaborator
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Excellent enhancement to this! Definitely will make future codemods for the remaining callback API epic that much easier 🚀
thatblindgeye
requested changes
Mar 16, 2023
packages/eslint-plugin-pf-codemods/lib/rules/v5/dataListCheck-updated-callback.js
Outdated
Show resolved
Hide resolved
thatblindgeye
approved these changes
Mar 16, 2023
gitdallas
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends rule helper added in #306 and test helper added in #334. Allows the rule helper to automate more of the needed changes and tests which ensure the helper additions are functioning properly.
Also closes #339