fix(DataViewFilters): add accessible name to filter category toggle - #687
Open
aloktomarr wants to merge 1 commit into
Open
fix(DataViewFilters): add accessible name to filter category toggle#687aloktomarr wants to merge 1 commit into
aloktomarr wants to merge 1 commit into
Conversation
The category-selector MenuToggle rendered only an icon plus activeAttributeMenu, which starts empty and is populated after first render, so screen readers saw an unnamed button (critical axe button-name violation, WCAG 4.1.2). Add a fallback aria-label to the toggle and initialize the active category synchronously from the first filter's title so the control is never empty. Includes a regression test. Fixes patternfly#680
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DataViewFilters category-selector MenuToggle renders only an icon plus activeAttributeMenu, which starts empty and is populated after the first render. Screen readers therefore saw an unnamed button — a critical axe button-name violation (WCAG 4.1.2).
This adds a fallback aria-label ("Filter by") to the toggle and initializes the active category synchronously from the first filter's title so the control is never empty. Includes a regression test asserting the toggle has an accessible name.
One note for review: the static aria-label becomes the accessible name (over the visible category text). Happy to switch to a dynamic Filter by {category} if you'd prefer the name to include the active category (WCAG 2.5.3).
Fixes #680