Skip to content

Exchange OIDC token before dart pub publish - #1830

Merged
benalleng merged 1 commit into
payjoin:masterfrom
spacebear21:dart-publish-oidc
Aug 21, 2026
Merged

Exchange OIDC token before dart pub publish#1830
benalleng merged 1 commit into
payjoin:masterfrom
spacebear21:dart-publish-oidc

Conversation

@spacebear21

Copy link
Copy Markdown
Collaborator

Fix the hung workflow at https://github.com/payjoin/rust-payjoin/actions/runs/32496950357/job/96822481525 due to the OIDC token not getting through to the nix environment.

Pull Request Checklist

Please confirm the following before requesting review:

The publish job granted id-token: write but nothing requested a
token, so dart pub publish found no credentials and fell back to the
interactive browser sign-in flow, hanging the job on a localhost
redirect. The official dart-lang/setup-dart action performs this
exchange as a side effect of installing the SDK; this repository
installs Dart through nix, so the exchange never happened.

Add contrib/publish.sh to request the GitHub OIDC token with audience
https://pub.dev, register it with dart pub token add, and publish,
and call it from the workflow. Add curl and jq to the dart devshell
so the script runs entirely from flake-provided tools.
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 32511811032

Coverage remained the same at 86.718%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 16458
Covered Lines: 14272
Line Coverage: 86.72%
Coverage Strength: 343.52 hits per line

💛 - Coveralls

@benalleng benalleng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e5ba93e

@benalleng
benalleng merged commit f56cb99 into payjoin:master Aug 21, 2026
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants