fix(drizzle): size sqlite batch inserts by widest row - #17234
Open
r1tsuu wants to merge 1 commit into
Open
Conversation
Batch size was derived from the first row's column count, but Drizzle emits one bound parameter per populated column per row. When later rows were wider than the first, a batch could exceed the bound parameter limit (e.g. D1's "too many SQL variables"). Size batches by the widest row instead.
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch size was derived from the first row's column count, but Drizzle emits one bound parameter per populated column per row. When later rows were wider than the first, a batch could exceed the bound parameter limit (e.g. D1's "too many SQL variables"). Size batches by the widest row instead.
Fixes #16964