fix(ui): resolve named-tab field permissions in bulk edit field select (3.x backport of #17523) - #17524
Merged
Conversation
PatrikKozak
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
July 28, 2026 16:13
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
paulpopus
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport to #17523 to
3.x.Resolves fields nested inside a named tab against the tab's own nested permission map in the bulk edit field select.
A named tab nests its subfields' permissions under
[tab.name].fields, like a group. The tabs branch ofreduceFieldOptionspassed the parent-level permissions straight into a named tab's subfields instead of descending into that map. This surfaced once a collection's permissions resolved to a detailed object — which happens as soon as any field definesaccess(e.g.update: () => false); a plaintruemasked it — with two effects:getFieldPermissionsfell back to the tab's own blanketupdate: trueinherited from the parent.The fix descends into
fieldPermissions[tab.name].fields(collapsing totruewhen the tab is fully granted), matching howGroupandArrayunwrap.fieldsbefore rendering their children.Covered by an isolated
reduceFieldOptionsunit test (restricted field inside a named tab, nested named tabs, multiple named tabs) and a bulk-edit e2e assertion.