PDFCLOUD-5464 Add additional pdfRest tools#6
Conversation
d5943ff to
311cc70
Compare
|
Tests are currently failing simply because an expected patch to return EDIT: Or, we could add a test file with forms. I GUESS. 🤤 |
|
I had Codex review the tests against the (slightly) updated version of
Next steps: |
|
The XFA tests are failing because there's a warning and no output: 'No XFA forms were detected in the input PDF. No output was produced.' Probably the test should include a file with XFA forms (and since this is a public repo, it has to be something that is rights-cleared, btw). But also, #7 also relaxes the strictness a little so that there doesn't have to be an output file. The tests in that module do happen to test both ways: returning a file, and just a warning. |
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
82429f7 to
e003088
Compare
|
@datalogics-kam I attempted to run the script but ran into trouble. Please see e003088. The report at the end showed test failures (hence, the latest force push), but I saw nothing in the printout that indicated there were differences between any synchronous and asynchronous tests. |
Resolve discrepancies in unit tests between sync and async Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
…ion tests Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
…arity Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
Assisted-by: Codex
- Excel - JPEG - PDF/A - Convert forms - OCR - Summarize - Translate - PDF/A (live) Assisted-by: Codex
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6bb55440a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6bb55440a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Assisted-by: Codex
Assisted-by: Codex
- Added `_EXPECTED_FILE_FORMATS`, `_expected_file_format`, and `_assert_output_files` helper. - Applied `_assert_output_files` in: - PNG success (sync + async) - Valid color model tests (all formats, sync + async) - Resolution bounds (PNG) - Valid smoothing tests (all formats, sync + async) - PNG page-range variants (sync + async) Assisted-by: Codex
datalogics-kam
left a comment
There was a problem hiding this comment.
- Tests are running.
- I believe all the issues have been addressed.
- If we find any other tuning of parameters or names, we can address it later.
- #22 will improve coverage testing and clean up some coverage issues.
PDFCLOUD-5464
Adds the following tools: