PDFCLOUD-5475 Add PDF compression#7
Merged
datalogics-cgreen merged 4 commits intopdfrest:mainfrom Jan 5, 2026
Merged
Conversation
- Introduced `compress_pdf` method for both synchronous and asynchronous `PdfRestClient` instances. - Added `PdfCompressPayload` to model validation with constraints for files, compression levels, profiles, and output settings. - Included live and unit tests to validate presets, custom profiles, request customization, and error handling. - Added new live test resources and sample compression profile. Assisted-by: Codex
- Compression might return just a warning.
- Require separate test cases for `PdfRestClient` and `AsyncPdfRestClient` in both unit and live test suites to verify synchronous and asynchronous behavior independently. Assisted-by: Codex
- Introduced `TESTING_GUIDELINES.md` to formalize expectations for unit and live tests across sync and async clients. - Detailed core principles, environment configuration, and validation patterns for robust API testing. - Covered transports, error handling, literal enumeration, and boundary value analysis. - Provided guidelines on mocking, file handling, request customization, and serialization to ensure complete coverage and consistency. - Added instructions for expanding tests as pdfRest evolves to support new APIs. Assisted-by: Codex
datalogics-cgreen
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDFCLOUD-5475
Summary
return IDs stay valid