Skip to content

Fix spack images - #35

Open
iole-bolognesi wants to merge 29 commits into
v4from
fix_spack_images
Open

Fix spack images#35
iole-bolognesi wants to merge 29 commits into
v4from
fix_spack_images

Conversation

@iole-bolognesi

@iole-bolognesi iole-bolognesi commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes issue #34

@iole-bolognesi
iole-bolognesi marked this pull request as ready for review June 26, 2026 06:34
jmorice91
jmorice91 reviewed Jun 29, 2026
View reviewed changes
Comment thread spack/2-spackbase/Dockerfile Outdated
jmorice91
jmorice91 reviewed Jun 29, 2026
View reviewed changes

@jmorice91 jmorice91 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

Comment thread spack/3-baselibs/clang.lst Outdated
Comment thread spack/3-baselibs/Dockerfile Outdated
JAuriac
JAuriac reviewed Jun 30, 2026
View reviewed changes
Comment thread spack/3-baselibs/Dockerfile Outdated
Comment thread spack/3-baselibs/Dockerfile
Comment thread spack/3-baselibs/Dockerfile
Comment thread spack/3-baselibs/Dockerfile
Comment thread spack/3-baselibs/Dockerfile Outdated
Comment thread spack/3-baselibs/Dockerfile Outdated
Comment thread spack/3-baselibs/Dockerfile
Comment thread spack/3-baselibs/Dockerfile Outdated
@iole-bolognesi
using llvm native linker rather than gold plugin
e7a1429
@iole-bolognesi
Apply review comments : drop COMPILER_REF pin and refactor BOOT name …
e449b3a 
…to COMPILER_SPECIFIC_VARIANTS
@iole-bolognesi
fix indentation
d96d6ab
@iole-bolognesi
add spec to use lld linker for latest spack and clang image
cde58a9
@iole-bolognesi
try unify when possible in concretizer
c7ada36
@iole-bolognesi
inject build flags only in the build of doxygen package
f42369b
@iole-bolognesi
fix typo
3f5a168
@iole-bolognesi
add the additional syntax to packages.yaml rather than overwriting it
1a5b5fb
@iole-bolognesi
fix syntax error
3eb932a
@iole-bolognesi
change packages.yaml to only support LTO for doxygen package
33b7e57
@iole-bolognesi
skip the YAML heredoc entirely and use spack config add's dotted-path…
ca817da 
… form
@iole-bolognesi
Add quotes to EORUNs and add condition to set LTO flags to doxygen pa…
c1a8e5d 
…ckage only for the latest version of spack
@iole-bolognesi
change codename of debian release
530225d
benoitmartin88
benoitmartin88 previously requested changes Jul 16, 2026
View reviewed changes

@benoitmartin88 benoitmartin88 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes are required.

Comment thread .github/workflows/debuntu_docker_images.yml
Comment thread .github/workflows/spack_docker_images.yml Outdated
Comment thread spack/2-spackbase/Dockerfile Outdated
Comment thread spack/3-baselibs/Dockerfile Outdated
Comment thread spack/3-baselibs/Dockerfile Outdated
Comment thread spack/3-baselibs/Dockerfile
Comment thread spack/3-baselibs/Dockerfile Outdated
Comment thread spack/4-mini/Dockerfile
Comment thread spack/5-all/Dockerfile
Comment thread spack/6-finalize/Dockerfile
@iole-bolognesi
iole-bolognesi requested a review from jmorice91 July 27, 2026 07:14
@iole-bolognesi
iole-bolognesi requested a review from JAuriac August 4, 2026 07:12
JAuriac
JAuriac previously approved these changes Aug 5, 2026
View reviewed changes

@JAuriac JAuriac left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved despite failing CI, as this repository also needs #40
(May also revert Dockerfile 4/5/6 and github workflow for this PR)

Comment thread .github/workflows/spack_docker_images.yml
Comment thread spack/5-all/Dockerfile Outdated
Comment thread spack/4-mini/Dockerfile Outdated
Comment thread spack/6-finalize/Dockerfile Outdated
@JAuriac JAuriac mentioned this pull request Aug 5, 2026
Merged
Yushan-Wang
Yushan-Wang previously approved these changes Aug 5, 2026
View reviewed changes
Comment thread .github/workflows/spack_docker_images.yml
@iole-bolognesi @JAuriac
Update spack/4-mini/Dockerfile
77b557a 
Co-authored-by: JAuriac <56091659+JAuriac@users.noreply.github.com>
@iole-bolognesi
iole-bolognesi dismissed stale reviews from Yushan-Wang and JAuriac via 77b557a August 5, 2026 09:14
iole-bolognesi and others added 3 commits August 5, 2026 11:15
@iole-bolognesi @JAuriac
Update spack/6-finalize/Dockerfile
2787088 
Co-authored-by: JAuriac <56091659+JAuriac@users.noreply.github.com>
@iole-bolognesi @JAuriac
Update spack/5-all/Dockerfile
cdbb0b6 
Co-authored-by: JAuriac <56091659+JAuriac@users.noreply.github.com>
@iole-bolognesi @JAuriac
Update .github/workflows/spack_docker_images.yml
6d8c9d7 
Co-authored-by: JAuriac <56091659+JAuriac@users.noreply.github.com>
@jmorice91
jmorice91 requested a review from jbigot August 5, 2026 10:26
Yushan-Wang
Yushan-Wang previously approved these changes Aug 5, 2026
View reviewed changes
JAuriac
JAuriac previously approved these changes Aug 5, 2026
View reviewed changes

@JAuriac JAuriac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved despite failing CI, as this repository also needs both #40 and a PMIx versioning change on debian/unstable side (the current OpenMPI version is not yet built against the latest PMIx, versions mismatch)

@iole-bolognesi
iole-bolognesi dismissed benoitmartin88’s stale review August 6, 2026 08:18

Old review. Dismissing to be able to merge before holidays

@JAuriac
JAuriac dismissed stale reviews from Yushan-Wang and themself via 61a2cba August 6, 2026 11:04
JAuriac
JAuriac approved these changes Aug 6, 2026
View reviewed changes

@JAuriac JAuriac left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, after reapplying the "debian release" fix, needed due to a patch conflict (and the PMIx versioning change on debian/unstable side is still needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JAuriac JAuriac JAuriac approved these changes
@jmorice91 jmorice91 Awaiting requested review from jmorice91
@benoitmartin88 benoitmartin88 Awaiting requested review from benoitmartin88
@jbigot jbigot Awaiting requested review from jbigot
@Yushan-Wang Yushan-Wang Awaiting requested review from Yushan-Wang

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spack images failing with latest version of spack

5 participants

@iole-bolognesi @benoitmartin88 @JAuriac @Yushan-Wang @jmorice91