Skip to content

Fix: deep diff ignores double underscore entries. Switched to _BULK_HASH#8

Merged
AKrantzPS merged 2 commits into
mainfrom
fix/deep_diff_ignores-__-underscore
Jun 23, 2026
Merged

Fix: deep diff ignores double underscore entries. Switched to _BULK_HASH#8
AKrantzPS merged 2 commits into
mainfrom
fix/deep_diff_ignores-__-underscore

Conversation

@AKrantzPS

Copy link
Copy Markdown
Collaborator

This pull request introduces several improvements and fixes across configuration, code style, and testing. The main focus is on enhancing the handling of bulk hash attributes in the codebase, ensuring correct diff detection, and improving type annotations for clarity. Additionally, there are minor updates to Dependabot configuration for commit message consistency.

Bulk Hash Attribute Handling and Diff Improvements

  • Replaced all uses of __BULK_HASH and __BULK_HASH_CALCULATION_ERROR with _BULK_HASH and _BULK_HASH_CALCULATION_ERROR in collect.py to ensure these fields are not treated as private and ignored by diff tools like DeepDiff.
  • Added tests verifying that differences in _BULK_HASH are detected by the diff logic, and that double underscore-prefixed fields (e.g., __BULK_HASH) are ignored, explaining the rationale for the naming change.

Type Annotation and Code Style Improvements

  • Added explicit type annotations for lists and variables in collect.py to improve code clarity and maintainability. [1] [2]
  • Updated assignment of pandas DataFrame columns to use pd.Index for explicitness and consistency. [1] [2]

CI and Dependency Management

  • Updated .github/dependabot.yml to add commit message prefixes for dependency updates, standardizing messages for both general and CI-related dependency changes. [1] [2]

@AKrantzPS AKrantzPS merged commit 8004f4b into main Jun 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant