fix(token-selector): dont ask for connected account to fetch token data

[jjramirezn]

We were having undesirable behavior on the TokenAmountInput where the user was disconnected, the usd <-> token toggle was not loading. This PR fixes that by fetching token data even if there is no wallet connected (we don't need any of the wallet data for this)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 16, 2024 1:46pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes in this pull request primarily modify the tokenSelector.context.tsx file, specifically the TokenContextProvider component. The useAccount hook and its associated isConnected state have been removed, leading to a revised token price fetching logic that now depends solely on selectedTokenAddress and selectedChainID. The cleanup function and dependencies of the useEffect hook have also been adjusted to reflect these changes, streamlining the process of managing token data.

Changes

File	Change Summary
src/context/tokenSelector.context.tsx	Removed useAccount hook and isConnected state; updated token price fetching logic and useEffect dependencies.

Possibly related PRs

• fix: prefered token in localStorage doesn't match any currently fetched tokens #395: The changes in TokenSelector.tsx improve the logic for displaying tokens and balances, which is relevant to the modifications in tokenSelector.context.tsx that affect how token data is managed.
• feat(token-selector): show default tokens for connected wallets with no balance #424: The update in TokenSelector.tsx to enforce wallet connectivity aligns with the changes in tokenSelector.context.tsx, which now fetches token prices without checking if the user is connected.
• feat(token-input): show dollar sign for stablecoins #430: The modifications in TokenAmountInput regarding how token price information is accessed relate to the changes in tokenSelector.context.tsx, where the fetching logic has been streamlined.
• feat(request): pre-load requested pair on pay #432: The changes in Initial.view.tsx that involve token and chain selection are connected to the updates in tokenSelector.context.tsx, which now manages token fetching based on selected values.
• fix(request): recalculate route request pay #433: The restructuring of context usage in Initial.view.tsx to include selectedChainID and selectedTokenAddress directly relates to the changes made in tokenSelector.context.tsx.
• fix(request): correctly identify native tokens #434: The improvements in state management and clarity in Initial.view.tsx are relevant to the changes in tokenSelector.context.tsx, which also focuses on managing token data effectively.
• fix: request pay issues #443: The enhancements in request pay functionality and state handling in Initial.view.tsx are connected to the changes in tokenSelector.context.tsx, which streamline the token fetching process.

Suggested labels

Being worked on

Suggested reviewers

• Hugo0

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Hugo0]

Completely agreed on this!

[Hugo0]

agreed, nice.