fix: update error msg wen user reject tx + fix refund link render

[kushagrasarathe]

fixes TASK-8635 for prod

Note: pr for wallet goes separately 🫡

Summary by CodeRabbit

• Bug Fixes
  • Enhanced error messaging to ensure that users receive clearer and more processed error information.
  • Refined the display of refund messages so they appear only when all necessary details are available.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 4, 2025 6:07pm

[coderabbitai]

Walkthrough

The pull request updates the error handling in the OfframpConfirmView component. The handleError function now calls utils.ErrorHandler(error) to process errors instead of using the error message directly. Additionally, the refund message is rendered only when both showRefund is true and a createdLink is present. No changes were made to exported or public entities.

Changes

File Path	Summary
src/components/Offramp/Confirm.view.tsx	Updated error handling to use utils.ErrorHandler(error) and refined refund message rendering to check both showRefund and createdLink.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant V as OfframpConfirmView
    participant EH as utils.ErrorHandler

    U->>V: Triggers error condition
    V->>EH: Pass error for processing
    EH-->>V: Return processed error message
    V->>U: Display error message

Loading

sequenceDiagram
    participant V as OfframpConfirmView
    participant U as User

    V->>V: Evaluate refund rendering conditions
    alt Both showRefund & createdLink present
        V->>U: Display refund message
    else Condition not met
        V->>U: Do not display refund message
    end

Loading

Possibly related PRs

• fix: error state when amount exceed wallet balance #649: Addresses enhanced error messaging using the ErrorHandler, closely related to this PR’s error handling update.
• Release w/ Request flow fixes #446: Involves modifications in the OfframpConfirmView that intersect with the error handling and UI rendering changes made here.
• [TASK-7887] fix: remove lopping for status check in cross-chain cashout #602: Focuses on transaction handling and state within the same component, showing a direct relationship with the modifications in the error logic and refund conditions.

Suggested reviewers

• jjramirezn

Poem

Hey, hop along, dear friend,
I've tweaked the code to mend,
Errors now pass a friendly check,
Refunds show only when they connect.
A little code-rabbit dance we share,
🐰✨ Jumping in logic with flair!
Happy hops as code we repair!

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between acb5ede and 07efdce.

📒 Files selected for processing (1)

• src/components/Offramp/Confirm.view.tsx (2 hunks)

🧰 Additional context used

📓 Learnings (1)

src/components/Offramp/Confirm.view.tsx (1)

Learnt from: Hugo0
PR: peanutprotocol/peanut-ui#458
File: src/components/Offramp/Confirm.view.tsx:141-141
Timestamp: 2024-11-12T09:39:20.720Z
Learning: The `handleConfirm` function in `src/components/Create/Link/Confirm.view.tsx` is separate from the one in `src/components/Offramp/Confirm.view.tsx` and does not need to be renamed when refactoring `handleConfirm` in `src/components/Offramp/Confirm.view.tsx`.

🔇 Additional comments (2)

src/components/Offramp/Confirm.view.tsx (2)

527-538: LGTM! Improved error handling using utility function.

The change to use utils.ErrorHandler provides more consistent error message handling across the application.

---

998-1006: LGTM! Improved refund message visibility logic.

The additional check for createdLink ensures the refund message is only shown when a valid link exists, preventing potential confusion.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[notion-workspace]

Bug: fix cashout error message on both wallet and prod

[Hugo0]

@kushagrasarathe nit: althought 2 prs are needed, i dont think we need 2 pr reviews for this. can just merge directly