fix: remove network cost loading dep from req pay

[kushagrasarathe]

fixes TASK-8841

Summary by CodeRabbit

• Refactor
  • Improved the display of loading indicators during payment processing. The loading cues in fee details now activate only when appropriate, ensuring more consistent and accurate feedback for users during transactions.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 6, 2025 4:34pm

[coderabbitai]

Walkthrough

This change updates the loading logic in the InitialView component. The conditions for the loading prop of both the FeeDescription and InfoRow components have been simplified by removing checks for Number(feeCalculations.networkFee.expected) === 0 and Number(feeCalculations.totalMax) === 0, respectively. The logic now focuses on evaluating Number(feeCalculations.estimatedFee) === 0 and the combined condition !isPayInitiatedByUser && isLoading for rendering the loading state.

Changes

File	Change Summary
src/.../Initial.view.tsx	Updated the loading prop conditions for FeeDescription (removed networkFee.expected check) and for InfoRow (removed totalMax check).

Sequence Diagram(s)

sequenceDiagram
    participant IV as InitialView
    participant FD as FeeDescription
    participant IR as InfoRow

    IV->>FD: Check: (Number(feeCalculations.estimatedFee) === 0 OR (!isPayInitiatedByUser && isLoading))
    FD-->>IV: Render with loading state based on condition
    IV->>IR: Check: (!isPayInitiatedByUser && isLoading)
    IR-->>IV: Render with loading state based on condition

Loading

Possibly related PRs

• Fix fetching tx fee #379: Introduces new state variables and refactors fee estimation in the same file, relating to changes in loading logic.
• Release w/ Request flow fixes #446: Alters the InitialView component by modifying the loading prop handling, which is similar to this PR.
• fix(request): allow user to connect on request pay page #449: Adjusts loading state logic for the FeeDescription and InfoRow components, aligning closely with the modifications in this PR.

Suggested reviewers

• Hugo0

Poem

Hoppin' through the code, I skip with glee,
Simplified loading checks now set us free.
No extra conditions to slow our pace,
Each component shines in its rightful place.
Code's a garden where logic blooms bright—
A bunny cheers, coding day and night! 🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bbe15e7 and ab1c8b1.

📒 Files selected for processing (1)

• src/components/Request/Pay/Views/Initial.view.tsx (1 hunks)

🧰 Additional context used

📓 Learnings (1)

src/components/Request/Pay/Views/Initial.view.tsx (2)

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#422
File: src/components/Request/Pay/Views/Initial.view.tsx:76-78
Timestamp: 2024-11-12T09:39:20.720Z
Learning: In `src/components/Request/Pay/Views/Initial.view.tsx`, both `txFee` and `utils.formatTokenAmount(estimatedGasCost, 3)` return strings, ensuring consistent return types for `calculatedFee`.

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#422
File: src/components/Request/Pay/Views/Initial.view.tsx:76-78
Timestamp: 2024-11-12T09:39:20.720Z
Learning: In `src/components/Request/Pay/Views/Initial.view.tsx`, both `txFee` and `utils.formatTokenAmount(...)` return strings, ensuring that `calculatedFee` consistently returns a string without the need for additional type conversion.

🔇 Additional comments (1)

src/components/Request/Pay/Views/Initial.view.tsx (1)

447-447: LGTM! Simplified loading condition.

The loading condition for FeeDescription has been simplified to focus on estimatedFee and user-initiated loading state, which aligns with the PR objective of removing network cost loading dependency.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[notion-workspace]

🪲 Bug: Fee loading when it should be loaded in request