Skip to content

fix : update appkit config#688

Merged
kushagrasarathe merged 4 commits intopeanut-wallet-devfrom
test/wallet-appkit-config
Feb 12, 2025
Merged

fix : update appkit config#688
kushagrasarathe merged 4 commits intopeanut-wallet-devfrom
test/wallet-appkit-config

Conversation

@kushagrasarathe
Copy link
Copy Markdown
Contributor

@kushagrasarathe kushagrasarathe commented Feb 12, 2025

Summary by CodeRabbit

  • New Features
    • Expanded network connectivity with support for additional prominent networks.
  • Improvements
    • Enhanced session initialization through updated cookie management for a smoother user experience.
    • Restructured network handling for improved performance and reliability.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
peanut-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 7:21pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 12, 2025

Walkthrough

This pull request updates two configuration files to enhance provider functionality. In the peanut configuration, the config.ContextProvider component now receives a cookies prop set to null. In the wagmi configuration, network management is revised by importing specific network constants, and the ContextProvider signature is updated to include a cookies parameter. Additionally, the wagmi configuration derives its initial state via a cookie utility and comments out certain adapter properties. These changes adjust how cookie data and network settings are managed within the providers.

Changes

File(s) Summary of Changes
src/config/peanut.config.tsx
src/config/wagmi.config.tsx
Updated ContextProvider functions to accept a cookies parameter (set to null in peanut and of type `string
src/config/wagmi.config.tsx Added network constant imports and defined a networks array replacing previous chain constants; commented out transports and connectors properties in the adapter.

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant ContextProvider
  participant CookieProcessor
  participant ProviderComponent

  Caller->>ContextProvider: Call with (cookies)
  alt In wagmi.config.tsx
    ContextProvider->>CookieProcessor: cookieToInitialState(cookies)
    CookieProcessor-->>ContextProvider: initialState
    ContextProvider->>ProviderComponent: Render WagmiProvider with initialState & networks
  else In peanut.config.tsx
    ContextProvider->>ProviderComponent: Render Provider with cookies=null
  end
Loading

Possibly related PRs

  • fix: bump appkit version + add defaultNetwork #608: The changes in the main PR regarding the ContextProvider function in src/config/peanut.config.tsx are related to the modifications made to the ContextProvider function in src/config/wagmi.config.tsx, as both involve updates to the function's signature to include a cookies parameter.

Poem

I'm a rabbit of code, hopping with cheer,
Cookies in tow, the change is so clear.
Providers now carry a fresh cookie treat,
Networks align in a rhythmic beat.
With lines of code crisp like a crunchy snack,
I celebrate these changes, hopping right back!
🥕💻


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3ce625e and 43ee76a.

📒 Files selected for processing (1)
  • src/config/wagmi.config.tsx (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Deploy-Preview
🔇 Additional comments (4)
src/config/wagmi.config.tsx (4)

4-15: LGTM!

The imports are well-structured and correctly aligned with the network configuration changes.

Also applies to: 18-18


34-37: LGTM!

The networks array is well-typed and includes all necessary networks. The previous concern about the scroll network has been addressed.


40-44: LGTM!

The wagmiAdapter and createAppKit configurations are consistent and properly utilize the new networks constant.

Also applies to: 47-63


65-74: Verify cookie handling implementation.

The ContextProvider implementation looks good with proper documentation and type safety. However, let's verify the cookie handling implementation across the codebase.

Let's check how cookies are handled in other files:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Description: Check cookie handling implementation across the codebase

# Search for cookie-related code
rg -i 'cookies?' --type tsx --type ts

# Search for cookieToInitialState usage
rg 'cookieToInitialState' --type tsx --type ts

Length of output: 142


Let's re-run the search using globs for TypeScript files instead of relying on the built-in file types.

Please run the above script, and we'll continue our analysis based on the output.


🏁 Script executed:

#!/bin/bash
# Re-run search for cookieToInitialState usage in TS and TSX files
echo "Searching for 'cookieToInitialState' in TS and TSX files..."
rg --ignore-case "cookieToInitialState" -g "*.tsx" -g "*.ts"

echo ""

# Re-run search for cookies-related code in TS and TSX files
echo "Searching for 'cookies' in TS and TSX files..."
rg --ignore-case "cookies" -g "*.tsx" -g "*.ts"

Length of output: 4077


Cookie handling implementation confirmed.

The usage of cookieToInitialState in ContextProvider conforms with the rest of the codebase’s cookie handling practices. The implementation and documentation are consistent—cookies are correctly processed and passed to derive the initial state.

  • The cookieToInitialState function is imported and utilized properly in src/config/wagmi.config.tsx.
  • Other parts of the codebase consistently use cookie handling patterns with Next.js cookies and js-cookie.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kushagrasarathe kushagrasarathe changed the title [WIP] : new appkit config fix : update appkit config Feb 12, 2025
@kushagrasarathe kushagrasarathe merged commit 0ae91bd into peanut-wallet-dev Feb 12, 2025
This was referenced Feb 13, 2025
@coderabbitai coderabbitai bot mentioned this pull request Apr 16, 2025
@Hugo0 Hugo0 deleted the test/wallet-appkit-config branch July 3, 2025 18:23
@coderabbitai coderabbitai bot mentioned this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants