Skip to content

fix: bump appkit version + add defaultNetwork#608

Merged
kushagrasarathe merged 1 commit intopeanut-walletfrom
fix/wc-access-pwa
Jan 7, 2025
Merged

fix: bump appkit version + add defaultNetwork#608
kushagrasarathe merged 1 commit intopeanut-walletfrom
fix/wc-access-pwa

Conversation

@kushagrasarathe
Copy link
Copy Markdown
Contributor

@kushagrasarathe kushagrasarathe commented Jan 7, 2025

Summary by CodeRabbit

  • Dependencies

    • Updated @reown/appkit to version 1.6.4-rc.0
    • Added testing library dependencies
    • Downgraded @testing-library/jest-dom to version ^6.4.2
    • Removed @types/web-push dependency
  • Configuration

    • Set default network to Ethereum mainnet
    • Removed domain restrictions for safe connector

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
peanut-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 6:03pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 7, 2025

Walkthrough

This pull request focuses on updating dependency versions in the package.json file and modifying the Wagmi configuration. The changes include updating the @reown/appkit dependency to a release candidate version, adjusting testing library dependencies, and removing the @types/web-push type definition. In the Wagmi configuration, the mainnet network is imported and set as the default network, and the allowedDomains property for the safe connector is removed.

Changes

File Change Summary
package.json - Updated @reown/appkit to 1.6.4-rc.0
- Added @testing-library/react@^16.1.0
- Added @testing-library/user-event@^14.5.2
- Downgraded @testing-library/jest-dom to ^6.4.2
- Removed @types/web-push
src/config/wagmi.config.tsx - Imported mainnet from viem/chains
- Removed allowedDomains from safe connector
- Added defaultNetwork: mainnet to createAppKit

Sequence Diagram

sequenceDiagram
    participant App
    participant WagmiConfig
    participant MainnetNetwork
    
    App->>WagmiConfig: Initialize with configuration
    WagmiConfig->>MainnetNetwork: Set as default network
    WagmiConfig-->>App: Configuration complete
Loading

Possibly related PRs

Suggested reviewers

  • Hugo0

Poem

🐰 Hop, hop, dependencies dance,
Mainnet springs forth with a glance!
Version bumps, a rabbit's delight,
Configuration takes a playful flight.
Code evolves with each gentle leap! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca4341b and b7cb1b2.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json (3 hunks)
  • src/config/wagmi.config.tsx (2 hunks)
🔇 Additional comments (5)
src/config/wagmi.config.tsx (2)

7-7: LGTM: Import statement correctly added

The mainnet import from viem/chains is properly added and used in the configuration.


57-57: Verify the impact of setting mainnet as defaultNetwork

Setting mainnet as the default network might affect users who primarily operate on other networks. Please ensure this aligns with the application's intended behavior and user expectations.

Consider:

  1. Does this change affect existing users who might be using other networks?
  2. Is there clear documentation or UI indication about the default network?
  3. Is there a smooth fallback mechanism if mainnet is not suitable for the user's needs?
package.json (3)

86-87: LGTM: Testing library updates

The addition of @testing-library/react and @testing-library/user-event will improve testing capabilities.


34-35: ⚠️ Potential issue

Verify compatibility between appkit and its adapter

There's a potential version mismatch:

  • @reown/appkit: 1.6.4-rc.0
  • @reown/appkit-adapter-wagmi: ^1.6.0

Using a release candidate version (1.6.4-rc.0) in production might introduce instability. Additionally, ensure the adapter is compatible with this RC version.

Consider:

  1. Is there a stable version available instead of the RC?
  2. Has this RC version been thoroughly tested?
  3. Should the adapter version be updated to match?

86-87: Verify web-push type definitions removal

The @types/web-push package is being removed while the web-push dependency remains in use. This might lead to TypeScript compilation issues.

Run this script to check for web-push usage:

Also applies to: 99-99


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant