This repository was archived by the owner on Feb 1, 2026. It is now read-only.
Update HTML_Common for PHP7.4+ - #3
Closed
MisterIcy wants to merge 7 commits into
Closed
Conversation
Refactor HTML_Common for PHP7.4
golgote
reviewed
Jun 29, 2022
| * @static | ||
| */ | ||
| function charset($newCharset = null) | ||
| public function charset(?string $newCharset = null) |
Member
There was a problem hiding this comment.
I think that this function should be static because the charset is global.
Author
There was a problem hiding this comment.
My bad, didn't notice that the method was annotated with @static. The method was made static in d5b198c
golgote
reviewed
Jun 29, 2022
|
|
||
| if (is_array($attributes)) { | ||
| $charset = HTML_Common::charset(); | ||
| $charset = $this->charset(); |
Member
There was a problem hiding this comment.
Should use self::charset() instead because html_common is used to know which charset is used globally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the coming of PHP8.0, many legacy codebases "broke", for the newest major version contains a lot of changes which are incompatible with older code.
This pull request, contains several changes to modernize the HTML_Common class, of which one is of the greatest importance: the renaming of the class's constructor.
Furthermore a simple workflow was added with linting and basic static analysis, to ensure that the changes work and to facilitate future refactorings.