Support minSdk 23 for Gadgetbridge integration?

[rcrisanti]

I was playing around with the idea of adding PebbleKit2 support to Gadgetbridge, but I quickly realized their minSdk version is 23 and PebbleKit2's minSdk version is 24. I was wondering if it would be possible to lower the minSdk version to allow easier integration, or if there was a reason it was pinned to 24?

[matejdro]

Hm, I'm not sure. Any chance you can lower the minSDK and see if it builds and passes all lint checks?

[rcrisanti]

Ok yeah I gave it a shot and looks like it would take some work to adapt. I get some build errors like

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':client-java:lintDebug' (registered by plugin 'com.android.internal.library').
> Lint found errors in the project; aborting build.

  Fix the issues identified by lint, or create a baseline to see only new errors.
  To create a baseline, run `gradlew updateLintBaseline` after adding the following to the module's build.gradle file:
  ```
  android {
      lint {
          baseline = file("lint-baseline.xml")
      }
  }
  ```
  For more details, see https://developer.android.com/studio/write/lint#snapshot

  Lint found 10 errors. First failure:

  /.../PebbleKitAndroid2/client-java/src/main/kotlin/io/rebble/pebblekit2/client/java/BaseJavaPebbleListenerService.kt:63: Error: Call requires API level 24, or core library desugaring (current min is 23): java.util.function.Consumer#accept [NewApi]
          responder.accept(ReceiveResult.Nack)
                    ~~~~~~

Seeing as I got a response from GB saying they're ok force-overriding this, maybe this isn't high priority to fix

[matejdro]

Hm, is the only java project a problem? At worst, we could lower the rest of them to SDK 23 and only keep java one at 24.

Alternatively, this might be solved by desugaring. Can you try enabling this on the java project: https://developer.android.com/studio/write/java8-support-table

Also, to integrate into GB, you only need server and common. client and client-java can stay as-is.