unnecessary restriction for "direct peering sessions" peers to be on the same subnet

[syntax-terr0r]

Hi there,
I've just stumbled across a restriction in PM that does not allow for BGP peers in direct peering session to be on different subnets.
There is however no technical reason in my point of view that would prevent this.
For example we have an active multihop eBGP session between two peers in completely different subnets which works just fine.
But due to this restriction we can not migrate this session to our PM instance.

Is there any specific reason why this restriction is in place?
As said before, I don't think it's strictly necessary?
Or at least it could be relaxed if "multihop" is set to a value > 1.

We will have to adapt the code for our purposes and could contribute a PR if desired.
Any thoughts on this?

[gmazoyer]

This is weird. The need for the local and remote IPs to be in the same network should only apply if the multihop TTL is equal to 1 as it can be seen here.

What version are you running? How are you creating the session so I can try to reproduce the issue?

[syntax-terr0r]

Of course, you're right.
I should have checked the code myself.

Turns out there is an additional issue on our side of the integration that made it look like the same issue even with multihop set to 1.
We can close this. Sorry for the noise.

[gmazoyer]

No worries, happy to help.

[syntax-terr0r]

Resolved