feat: Add excluding for categories - #143
Open
arnesetzer wants to merge 2 commits into
Open
Conversation
Joxit
requested changes
Sep 11, 2026
Joxit
left a comment
Joxit
left a comment
Member
There was a problem hiding this comment.
Hi,
Thank you for using pelias and submitting PR 😄
I put some comments in your code.
Could you also keep the same indentation / code style on all unchanged lines ? This will help us for the review and reduce the number of unnecessary changes.
arnesetzer
force-pushed
the
feat/categories-exclude
branch
from
September 11, 2026 16:25
bcb0954 to
c52f0a3
Compare
arnesetzer
force-pushed
the
feat/categories-exclude
branch
from
September 11, 2026 16:31
c52f0a3 to
e17334a
Compare
Author
|
Fixed the mix up. Sorry again. After running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
This is the first of two PRs who needs to be merged together. The second one is here: pelias/api#1725
Here's the reason for this change 🚀
For a project I need the functionality to exclude categories like layers which is currently not possible. Maybe it is a useful thing to have on upstream.
Here's what actually got changed 👏
Here's how others can test the changes 👀