Skip to content

Charles/fix actions - #2444

Merged
notAreYouScared merged 4 commits into
mainfrom
charles/fix-actions
Jul 11, 2026
Merged

Charles/fix actions#2444
notAreYouScared merged 4 commits into
mainfrom
charles/fix-actions

Conversation

@notAreYouScared

Copy link
Copy Markdown
Member

Its not pretty code wise, but the buttons are fixed :)
image

image

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2b6b55d1-6839-469f-a117-29c8883e07f7

📥 Commits

Reviewing files that changed from the base of the PR and between b3356bc and a0a5f93.

📒 Files selected for processing (1)
  • app/Filament/Admin/Pages/ListLogs.php
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/Filament/Admin/Pages/ListLogs.php

📝 Walkthrough

Walkthrough

The ListLogs admin page adds bulk download/delete actions, hardens log uploading with file checks and truncation, and improves tooltip and response handling. CreateSchedule changes the create-action label from __() to trans().

Changes

ListLogs bulk actions and hardening

Layer / File(s) Summary
Imports and toolbar bulk-action wiring
app/Filament/Admin/Pages/ListLogs.php
Adds plugin and bulk-action imports and registers grouped bulk download/delete actions in toolbarActions().
Bulk download/delete action implementations
app/Filament/Admin/Pages/ListLogs.php
Bulk download collects selected dates for downloadLogs(), while bulk delete iterates records and calls deleteLog().
Tooltip formatting and uploadLogs hardening
app/Filament/Admin/Pages/ListLogs.php
The tooltip uses typed null-safe date formatting; uploadLogs checks the file, truncates content to 1,000 lines, uploads multipart data, and safely extracts the response URL.

CreateSchedule translation call update

Layer / File(s) Summary
Translation function replacement
app/Filament/Server/Resources/Schedules/Pages/CreateSchedule.php
The create-form action label switches from __() to trans() with the same translation key.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant ListLogs
  participant FilamentLogViewerPlugin

  User->>ListLogs: trigger bulk download action
  ListLogs->>ListLogs: pluck selected dates
  ListLogs->>FilamentLogViewerPlugin: downloadLogs(dates)
  alt success
    FilamentLogViewerPlugin-->>ListLogs: file response
    ListLogs-->>User: return response
  else exception
    FilamentLogViewerPlugin-->>ListLogs: throws exception
    ListLogs->>ListLogs: action.failure()
    ListLogs-->>User: return null
  end
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is too vague and reads like a branch name, so it doesn't clearly describe the change. Use a concise title that names the main change, such as fixing the log page bulk actions.
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is loosely worded, but it clearly refers to fixing the buttons in the changed UI.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lancepioch
lancepioch requested a review from Boy132 July 9, 2026 13:31
@notAreYouScared
notAreYouScared merged commit 4cd8b57 into main Jul 11, 2026
16 checks passed
@notAreYouScared
notAreYouScared deleted the charles/fix-actions branch July 11, 2026 19:31
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants