Charles/fix actions - #2444
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe ListLogs admin page adds bulk download/delete actions, hardens log uploading with file checks and truncation, and improves tooltip and response handling. CreateSchedule changes the create-action label from ChangesListLogs bulk actions and hardening
CreateSchedule translation call update
Sequence Diagram(s)sequenceDiagram
participant User
participant ListLogs
participant FilamentLogViewerPlugin
User->>ListLogs: trigger bulk download action
ListLogs->>ListLogs: pluck selected dates
ListLogs->>FilamentLogViewerPlugin: downloadLogs(dates)
alt success
FilamentLogViewerPlugin-->>ListLogs: file response
ListLogs-->>User: return response
else exception
FilamentLogViewerPlugin-->>ListLogs: throws exception
ListLogs->>ListLogs: action.failure()
ListLogs-->>User: return null
end
Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lancepioch
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its not pretty code wise, but the buttons are fixed :)
