Skip to content

Fix CreateWebhookConfiguration HeaderActions - #1979

Merged
rmartinoscar merged 1 commit into
mainfrom
issue/1974
Dec 10, 2025
Merged

Fix CreateWebhookConfiguration HeaderActions#1979
rmartinoscar merged 1 commit into
mainfrom
issue/1974

Conversation

@rmartinoscar

Copy link
Copy Markdown
Member

Closes #1974

@coderabbitai

coderabbitai Bot commented Dec 10, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Added icon customization to header actions in the webhook creation page. The cancel action now displays a left arrow icon and the create action displays a file plus icon, addressing visibility of form controls.

Changes

Cohort / File(s) Summary
Webhook Configuration Icons
app/Filament/Admin/Resources/Webhooks/Pages/CreateWebhookConfiguration.php
Added ->icon('tabler-arrow-left') to cancel action and ->icon('tabler-file-plus') to create action in header actions, improving UI visibility of form controls

Possibly related PRs

  • pelican-dev/panel#1959: Modifies the same CreateWebhookConfiguration file with related header action customizations for cancel and create buttons

Pre-merge checks

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the primary change: adding icon customization to HeaderActions in CreateWebhookConfiguration.
Description check ✅ Passed The description references issue #1974 which is directly related to the changeset fixing the missing save button icon.
Linked Issues check ✅ Passed The PR adds icons to both cancel and create actions, directly addressing issue #1974's complaint about missing/invisible save button by making it visible with proper icon styling.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing the CreateWebhookConfiguration header actions icons as required by issue #1974; no unrelated modifications present.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dfd6dbf and db47f1d.

📒 Files selected for processing (1)
  • app/Filament/Admin/Resources/Webhooks/Pages/CreateWebhookConfiguration.php (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-05T22:21:31.863Z
Learnt from: notAreYouScared
Repo: pelican-dev/panel PR: 1865
File: app/Filament/Admin/Resources/Nodes/Pages/EditNode.php:682-682
Timestamp: 2025-11-05T22:21:31.863Z
Learning: In app/Filament/Admin/Resources/Nodes/Pages/EditNode.php, the diagnostics tab's upload action intentionally does not use the iconButton() modifier, while the pull action does. This UI difference is intentional.

Applied to files:

  • app/Filament/Admin/Resources/Webhooks/Pages/CreateWebhookConfiguration.php
🧬 Code graph analysis (1)
app/Filament/Admin/Resources/Webhooks/Pages/CreateWebhookConfiguration.php (1)
app/Filament/Admin/Pages/Health.php (1)
  • icon (165-174)
🔇 Additional comments (1)
app/Filament/Admin/Resources/Webhooks/Pages/CreateWebhookConfiguration.php (1)

28-32: LGTM! Fixes the missing save button issue.

Adding explicit icons to the header action buttons resolves the visibility problem reported in issue #1974. The icon choices are semantically appropriate:

  • tabler-arrow-left for the cancel action (standard back/navigation pattern)
  • tabler-file-plus for the create action (clear creation intent)

The buttons were already configured as icon buttons with size, but lacked the actual icon specification, which caused them to be invisible or only visible on hover.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rmartinoscar
rmartinoscar merged commit 091ca54 into main Dec 10, 2025
25 checks passed
@rmartinoscar
rmartinoscar deleted the issue/1974 branch December 10, 2025 19:39
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save Webhook Event icon missing

2 participants