Fix schedule actions - #1992
Merged
Merged
Conversation
the edit view is the first view and view requires a url edit to see the run now button..
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughCentralizes the DeleteAction icon in FilamentServiceProvider, removes explicit Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FilamentUI as Filament (UI)
participant Auth as Authorization
participant TenantCtx as Filament Facade (tenant)
participant ProcessSvc as ProcessScheduleService
participant ActivityLog as Activity
participant Form as Schedule Form
User->>FilamentUI: Click "Run Now" (run_now action)
FilamentUI->>TenantCtx: resolve current tenant & schedule
FilamentUI->>Auth: check SubuserPermission::ScheduleUpdate for tenant
Auth-->>FilamentUI: authorized / denied
alt authorized
FilamentUI->>ProcessSvc: ProcessScheduleService::handle(schedule, true)
ProcessSvc-->>FilamentUI: success / failure
FilamentUI->>ActivityLog: record "server:schedule.execute" with schedule name
FilamentUI->>Form: fillForm() (refresh)
FilamentUI-->>User: update UI (toast/state)
else denied
FilamentUI-->>User: show authorization error
end
Possibly related PRs
Pre-merge checks❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
No reason to have it, acts like a back button...
Boy132
approved these changes
Dec 12, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
Run Nowto edit the page, as it's the first page when a schedule is editable.Fixed the delete action icon missing.