Skip to content

Fix translations workflow not opening PRs - #2403

Merged
lancepioch merged 1 commit into
mainfrom
fix/crowdin-translations-pr-auth
Jun 22, 2026
Merged

Fix translations workflow not opening PRs#2403
lancepioch merged 1 commit into
mainfrom
fix/crowdin-translations-pr-auth

Conversation

@lancepioch

@lancepioch lancepioch commented Jun 22, 2026

Copy link
Copy Markdown
Member

The weekly Crowdin workflow has been failing on every run. Download + Pint both work fine, it just dies on the Create Pull Request step.

Two things were going on:

  1. checkout@v6 keeps its auth header around, and create-pull-request adds its own on top, so git ends up sending the Authorization header twice and GitHub 400s with Duplicate header: "Authorization". Setting persist-credentials: false on checkout sorts it out (see remote: Duplicate header: "Authorization" error when used in conjunction with actions/checkout v6+ peter-evans/create-pull-request#4272). That's the only change in here.

  2. Before it even got that far it would've hit a 403 since Actions wasn't allowed to open PRs. Already flipped that on in the org/repo settings.

Once this is merged I'll kick off a manual run to make sure it actually opens the PR now.

actions/checkout@v6 persists an auth extraheader that collides with the
one peter-evans/create-pull-request adds, producing 'Duplicate header:
Authorization' and a git 400 on the Create Pull Request step. Set
persist-credentials: false so create-pull-request manages auth itself.

Refs: peter-evans/create-pull-request#4272, actions/checkout#2299
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The download-translations.yml workflow's "Checkout code" step gains a with block that sets persist-credentials: false, preventing GitHub Actions from storing credentials on disk after the checkout action completes.

Changes

Download Translations Workflow

Layer / File(s) Summary
Disable credential persistence on checkout
.github/workflows/download-translations.yml
Adds with: persist-credentials: false to the actions/checkout step so GitHub credentials are not retained after the checkout completes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'Fix translations workflow not opening PRs' directly describes the main issue being resolved in the changeset.
Description check ✅ Passed The description comprehensively explains the root causes of the workflow failure and the fix applied, with clear context about the duplicate Authorization header issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lancepioch lancepioch self-assigned this Jun 22, 2026
@lancepioch lancepioch changed the title ci: fix Crowdin translations PR creation Fix translations workflow not opening PRs Jun 22, 2026
@lancepioch
lancepioch merged commit 0f1aa46 into main Jun 22, 2026
16 checks passed
@lancepioch
lancepioch deleted the fix/crowdin-translations-pr-auth branch June 22, 2026 03:23
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant