Fix translations workflow not opening PRs - #2403
Merged
Merged
Conversation
actions/checkout@v6 persists an auth extraheader that collides with the one peter-evans/create-pull-request adds, producing 'Duplicate header: Authorization' and a git 400 on the Create Pull Request step. Set persist-credentials: false so create-pull-request manages auth itself. Refs: peter-evans/create-pull-request#4272, actions/checkout#2299
Contributor
📝 WalkthroughWalkthroughThe ChangesDownload Translations Workflow
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weekly Crowdin workflow has been failing on every run. Download + Pint both work fine, it just dies on the Create Pull Request step.
Two things were going on:
checkout@v6 keeps its auth header around, and create-pull-request adds its own on top, so git ends up sending the Authorization header twice and GitHub 400s with
Duplicate header: "Authorization". Settingpersist-credentials: falseon checkout sorts it out (seeremote: Duplicate header: "Authorization"error when used in conjunction withactions/checkoutv6+ peter-evans/create-pull-request#4272). That's the only change in here.Before it even got that far it would've hit a 403 since Actions wasn't allowed to open PRs. Already flipped that on in the org/repo settings.
Once this is merged I'll kick off a manual run to make sure it actually opens the PR now.