Fix backup hosts migration - #2468
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe backup host migration now adds ChangesBackup host migration
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
notAreYouScared
approved these changes
Jul 20, 2026
ItzExotical
added a commit
to officialhypefox/velrix-control
that referenced
this pull request
Jul 25, 2026
Brings in 6 upstream commits (installer redirect pelican#2438, backup-hosts migration fix pelican#2468, relation-manager cleanup pelican#2456, translations, test fixes). One conflict: the create_backup_hosts_table migration. Our fork carried an equivalent local fix for the same migration bug (adding backup_host_id nullable then tightening to NOT NULL after backfill); upstream pelican#2468 fixes it by deferring the FK + dropColumn('disk') to after the backfill. Both yield the identical final schema, so resolved in favor of upstream to keep the fork aligned for clean future merges. The Velrix SSO endpoint is unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2447
The migration failed with foreign key constraint errors because the foreign key was added before the table data was populated. Changing the order of operations and temporarily making the column nullable fixes these issues.