Add Fragment node for node grouping
#86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
With the introduction of fragment, I would like to deprecate render_node / iter_node (but keep them around for a long time). That can be done in a separate PR though! |
pelme
reviewed
Feb 5, 2025
pelme
reviewed
Feb 5, 2025
geigerzaehler
force-pushed
the
fragment
branch
from
3e544c0 to
a027a19
Compare
Merged
pelme
reviewed
Feb 5, 2025
Contributor
Author
|
Thanks for the quick feedback. I’ve updated the PR accordingly |
pelme
reviewed
Feb 5, 2025
Owner
|
the comment function should return a Fragment instead of Markup too. that makes it possible to render it directly |
geigerzaehler
force-pushed
the
fragment
branch
from
7fcb7ab to
3011348
Compare
Contributor
Author
|
I’ve addressed your comments and rebased the branch |
pelme
added a commit
that referenced
this pull request
Mar 8, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 8, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 8, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 8, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 9, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 14, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 14, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 14, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 14, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 15, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 15, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 15, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 15, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 16, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 16, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 16, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 20, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Mar 20, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces stream_chunks() which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant and they will be deprecated in another commit. This commit removes all internal usages of render_node and iter_node so they can be deprecated. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 10, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 10, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with __iter__() but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 10, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with `__iter__()`` but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 10, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with `__iter__()` but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 11, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with `__iter__()` but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 11, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with `__iter__()` but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 11, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with `__iter__()` but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 11, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with `__iter__()` but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 11, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with `__iter__()` but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 11, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with `__iter__()` but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 11, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with `__iter__()` but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 11, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with `__iter__()` but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 12, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with `__iter__()` but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
pelme
added a commit
that referenced
this pull request
Apr 12, 2025
This change provides a consistent API to render a htpy object as HTML or iterate over it. This commit introduces the iter_chunks() method which is identical with `__iter__()` but with a better name. With the introduction of Fragment, this commit makes render_node and iter_node redundant. This commit deprecates render_node, iter_node and direct iteration of elements. More info: #86 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very basic implementation of
Fragmentas discussed in #82.