fix: use Alchemy for Polygon Amoy RPC - #1301
Closed
naka-bot wants to merge 5 commits into
Closed
Conversation
👷 Deploy request for vortex-sandbox pending review.Visit the deploys page to approve it
|
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 54d9c5e |
👷 Deploy request for vrtx-dashboard pending review.Visit the deploys page to approve it
|
Contributor
There was a problem hiding this comment.
Pull request overview
Routes Polygon Amoy RPC traffic through Alchemy while retaining viem’s default transport as fallback.
Changes:
- Configure Alchemy as the preferred Polygon Amoy RPC.
- Apply equivalent behavior to transaction signing.
- Update RPC redaction and fallback tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
clientManager.ts |
Updates Polygon Amoy RPC ordering. |
clientManager.test.ts |
Updates redaction and fallback tests. |
signUnsigned.ts |
Uses Alchemy for Amoy signing clients. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Suppressed comments (1)
packages/shared/src/helpers/signUnsigned.ts:98
- The regression tests only inspect
getEvmNetworks; none exercises the changed Polygon Amoy branch insignUnsignedTransactions. Add a focused signing-helper test that verifies Alchemy is preferred when a key is supplied and viem's default transport remains the no-key fallback, so the SDK behavior claimed by this fix cannot regress independently of the client manager.
rpcUrls = apiKey ? [`https://polygon-amoy.g.alchemy.com/v2/${apiKey}`] : [];
| const NON_RETRYABLE_READ_CONTRACT_REVERTS = ["EXCEEDS_MAX_COVERAGE_RATIO"]; | ||
| // Any on-chain revert is deterministic for a given block state: retrying against a different RPC | ||
| // node will not change the outcome, so retrying just wastes calls and delays failure reporting. | ||
| const NON_RETRYABLE_READ_CONTRACT_ERROR_PATTERNS = [/execution reverted/i]; |
Comment on lines
+215
to
+218
| tx.network === Networks.Arbitrum || | ||
| tx.network === Networks.Avalanche || | ||
| tx.network === Networks.BSC || | ||
| tx.network === Networks.Ethereum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test
Note: this is meant to stop backend ephemeral freshness checks from hitting the public OnFinality rate limit during registerRamp.