fix(api): route sell quotes to settlement chains - #1304
Conversation
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vrtx-dashboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Code reviewFound 1 issue:
vortex/apps/api/src/api/services/phases/blocks/core/squidrouter.ts Lines 36 to 42 in 69977b5 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
There was a problem hiding this comment.
Pull request overview
Aligns SELL quote simulation with actual EVM settlement routes while improving deployed smoke coverage and dashboard test reliability.
Changes:
- Replaces legacy Moonbeam quote routing with Base/Polygon-aware Squid routes.
- Adds nightly deployed BUY/SELL quote smoke tests.
- Coalesces dashboard token refreshes and pins the E2E widget origin.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/e2e.yml |
Runs deployed quote smoke tests nightly. |
docs/operations-testing.md |
Documents deployed smoke coverage. |
apps/dashboard/playwright.config.ts |
Pins the mocked widget origin. |
apps/dashboard/src/services/auth.ts |
Adds shared in-flight token refreshes. |
apps/dashboard/src/services/auth.test.ts |
Tests concurrent refresh coalescing. |
apps/api/src/tests/deployed-quotes.e2e.test.ts |
Probes deployed BUY/SELL quotes. |
apps/api/src/api/services/phases/blocks/core/squidrouter.ts |
Uses direction-independent quote routes. |
apps/api/src/api/services/phases/blocks/core/squidrouter-route.ts |
Builds generic simulation routes. |
apps/api/src/api/services/phases/blocks/__tests__/squidrouter-quote-route.test.ts |
Verifies Base and Polygon settlement routing. |
apps/api/src/api/services/phases/blocks/__tests__/onramp-discount.test.ts |
Updates expected bridge request shape. |
apps/api/src/api/services/phases/blocks/phases/subsidize-post/simulation.ts |
Removes obsolete ramp direction. |
apps/api/src/api/services/phases/blocks/phases/squid-router-swap/simulation.ts |
Updates bridge simulation input. |
apps/api/src/api/services/phases/blocks/phases/mykobo-mint/simulation.ts |
Updates Mykobo bridge simulation. |
apps/api/src/api/services/phases/blocks/phases/evm-offramp-source/simulation.ts |
Routes SELL simulation to Base. |
apps/api/src/api/services/phases/blocks/phases/avenia-mint/index.ts |
Updates Avenia bridge quoting. |
apps/api/src/api/services/phases/blocks/phases/alfredpay-offramp/simulation.ts |
Routes Alfredpay simulation to Polygon. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
.github/workflows/e2e.yml:70
- This adds a non-Playwright failure source, but the downstream Slack alert still says “Nightly Playwright e2e run failed.” When only the deployed quote probe fails, responders receive a misleading diagnosis. Broaden the notification text to mention the e2e/smoke workflow.
- name: 🩺 Live BUY/SELL quote smoke tests
Summary
Testing
Scope
The quote hotfix removes legacy Moonbeam routing from quote creation. The separate moonbeamCleanup background-processing failure is not changed here.