Skip to content

Conversation

@brunobord
Copy link
Contributor

@brunobord brunobord commented Jun 19, 2018

Review

  • Tests
  • CHANGELOG.rst Updated
  • Delete your branch

@brunobord brunobord force-pushed the use-logger-exception-not-error branch from 82e133a to 193a0cc Compare July 23, 2018 08:35
@brunobord brunobord requested review from syldb and removed request for syldb August 17, 2018 14:25
Copy link

@syldb syldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@brunobord brunobord merged commit 6a45f4d into master Aug 20, 2018
@brunobord brunobord deleted the use-logger-exception-not-error branch August 20, 2018 08:02
brunobord added a commit that referenced this pull request Aug 20, 2018
- Added a plugin mechanism, allowing users to define and integrate their
  own "business logic" fields.
- Change the global exception handling error level, from "error" to
  "exception". It'll provide better insights if you're using Logmatic or
any other logging aggregator (#336).

**warning**: The plugin mechanism is on BETA mode, and at the moment, it only
allows to define business-logic fields at "form building time". It means
there's not business-logic validation mechanism when you're filling a
form previously defined with your custom field.
    This is a work in progress, please bear with us.

*Minor changes*

- Upgrade to Circle-CI 2 (before the end of life of Circle-CI v1 on
  August, 31st 2018). (#342)
- Optimize Circle-CI usage by using the tox matrix in tests (#343)
- Skip `tox` installation in the circle-ci environment: it's already
  there (#344).
@brunobord brunobord mentioned this pull request Aug 20, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants