CircleCI optimization: do not install tox, it's already there #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobord
force-pushed
the
circle-ci2-optimizations
branch
from
fdb7fe2 to
99bc7ac
Compare
and still, this `--user` install isn't used because the tox package installed by the docker image is the first in the `$PATH`.
brunobord
force-pushed
the
circle-ci2-optimizations
branch
from
99bc7ac to
3ff0e1d
Compare
Contributor
Author
|
would it be possible to validate this before starting the RC process, please? /cc @alexdashkov @syldlb |
alexdashkov
approved these changes
Aug 20, 2018
brunobord
added a commit
that referenced
this pull request
Aug 20, 2018
- Added a plugin mechanism, allowing users to define and integrate their own "business logic" fields. - Change the global exception handling error level, from "error" to "exception". It'll provide better insights if you're using Logmatic or any other logging aggregator (#336). **warning**: The plugin mechanism is on BETA mode, and at the moment, it only allows to define business-logic fields at "form building time". It means there's not business-logic validation mechanism when you're filling a form previously defined with your custom field. This is a work in progress, please bear with us. *Minor changes* - Upgrade to Circle-CI 2 (before the end of life of Circle-CI v1 on August, 31st 2018). (#342) - Optimize Circle-CI usage by using the tox matrix in tests (#343) - Skip `tox` installation in the circle-ci environment: it's already there (#344).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And still, this
--userinstall isn't used because the tox package installed by the docker image is the first in the$PATH.Review
CHANGELOG.rstUpdated