feat(ui): add TOC side panel and dropdown for page viewer#1247
Merged
Conversation
- Sticky TOC side panel (xl+) rendered via portal into app-toc-pane-root - TOC dropdown button in subheader for smaller screens - Shared scroll-spy hook (useTocScrollSpy) with atBottom detection so short paragraphs no longer prevent bottom headings from activating - URL hash updated via history.replaceState on TOC entry click - scrollToHeadlineHash now returns a cancel function; useScrollToHeadline uses it as useEffect cleanup to prevent stale replaceState on fast nav - Lifted useTocScrollSpy to PageViewer to eliminate duplicate listeners - overflow-hidden mobile guard moved to scroll-container (correct element) - .app-layout__content-row added to print overflow:visible rule - i18n keys: toc.title, toc.onThisPage - Tests: TocSidePanel (13), TocDropdownButton (8), scrollToHeadline (3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.