fix(auth): stop login flash on logout, add external user-management link#1268
Merged
Merged
Conversation
When httpRemoteUserLogoutUrl is configured, logging out cleared local session state before redirecting, which briefly flashed the local login screen before the browser navigated away. Now the redirect happens first and the server-side session is invalidated in the background. Also add an optional userManagementUrl config: when set, the in-app User Management entry becomes an external link and the /users route is disabled, following the same pattern as the existing logout URL. The backend /api/auth/users* routes are left untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When httpRemoteUserLogoutUrl is configured, logging out cleared local session state before redirecting, which briefly flashed the local login screen before the browser navigated away. Now the redirect happens first and the server-side session is invalidated in the background.
Also add an optional userManagementUrl config: when set, the in-app User Management entry becomes an external link and the /users route is disabled, following the same pattern as the existing logout URL. The backend /api/auth/users* routes are left untouched.