fix(editor): reset editor store on unmount so rename isn't blocked after closing#1283
Merged
Conversation
…ter closing usePageEditorStore never cleared `page` when PageEditor unmounted, so currentEditorPageId kept pointing at the last-edited page indefinitely. TreeNodeActionsMenu's rename check (unlike delete's) relies solely on that id without a route guard, so renaming a page via the tree's "..." menu was permanently blocked by a stale "currently being edited" toast once you'd edited it at least once, even long after closing the editor.
Local prettier (3.8.x, stale node_modules) formatted these differently than the 3.9.4 pinned in package.json, which CI installs via npm ci.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usePageEditorStore never cleared
pagewhen PageEditor unmounted, so currentEditorPageId kept pointing at the last-edited page indefinitely. TreeNodeActionsMenu's rename check (unlike delete's) relies solely on that id without a route guard, so renaming a page via the tree's "..." menu was permanently blocked by a stale "currently being edited" toast once you'd edited it at least once, even long after closing the editor.