Chore/pending fixes tree auth sidebar#1325
Merged
Merged
Conversation
Extend the shared RetryOnCorruption wipe-and-retry policy (already used by tags/links/properties/search/favorites) to the user and session SQLite stores, so a corrupted users.db/sessions.db self-heals on next start instead of leaving the store permanently broken.
Flip the --snapshot flag default from false to true now that the feature has been verified end-to-end.
Pressing the search hotkey while the search panel is already active now refocuses the input instead of doing nothing, via a searchFocusRequestId counter in the sidebar store since sidebarVisible/sidebarMode don't change value in that case.
…ions Replace display:none <-> flex toggling on the toc-pane with an always-mounted, always-flex 0-width box that only animates its width. Previously the pane's first appearance (mount) had no prior width to transition from, so <main> snapped to its narrower width in one frame while the subheader's padding-right (animated on an always-mounted node) still eased in over 200ms, causing a visible desync.
…on read-only - Replace the TreeDndContext React context with a treeDndStore zustand store so drag state updates (activeId/dropTarget) don't force a re-render of every TreeNode via context propagation. - Move the favorite toggle out of the always-visible tree row (FavoriteToggleButton) into TreeNodeActionsMenu as a dropdown item, available to any logged-in user regardless of read-only mode. - Wrap the mutating actions in TreeNodeActionsMenu (add/edit/rename/ copy/sort/move/convert/delete) behind useIsReadOnly(), matching the read-only guard already applied to the inline add-page button. - transition-colors instead of transition-all on .tree-node, since only color properties are animated there now.
The DELETE /api/pages/:id endpoint now requires a version query param for optimistic-concurrency checking; the perf test's cleanup helper was still calling it without one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.