fix(markdown): recover unquoted colon in leafwiki_* frontmatter fields#1332
Merged
Conversation
An externally-authored page whose leafwiki_title (or other leafwiki_* string field) contains an unquoted colon, e.g. "ADR-0001: Filesystem as Source of Truth", failed YAML frontmatter parsing entirely and was silently dropped from the tree during filesystem reconstruction. parseFrontmatterYAML now falls back to a real-parse-validated sanitizer that quotes leafwiki_* values which don't parse on their own (unquoted colons, but also stray backticks/@ signs), while leaving genuine YAML constructs (flow-collections, anchors, block scalars) alone so malformed ones keep failing loudly. The sanitizer is anchored to column 0 so it can never reach into an unrelated field's indented block-scalar content. Frontmatter now exposes WasRepaired(), and node_store logs a warning when a file's frontmatter needed this recovery, so auto-repair isn't silent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An externally-authored page whose leafwiki_title (or other leafwiki_* string field) contains an unquoted colon, e.g. "ADR-0001: Filesystem as Source of Truth", failed YAML frontmatter parsing entirely and was silently dropped from the tree during filesystem reconstruction.
parseFrontmatterYAML now falls back to a real-parse-validated sanitizer that quotes leafwiki_* values which don't parse on their own (unquoted colons, but also stray backticks/@ signs), while leaving genuine YAML constructs (flow-collections, anchors, block scalars) alone so malformed ones keep failing loudly. The sanitizer is anchored to column 0 so it can never reach into an unrelated field's indented block-scalar content.
Frontmatter now exposes WasRepaired(), and node_store logs a warning when a file's frontmatter needed this recovery, so auto-repair isn't silent.