fix: prefer exact title match over route-path for slash-containing wi… - #1381
Merged
Conversation
…kilinks A [[Title]] wikilink whose title contains a "/" (e.g. [[TCP/IP]]) tried a route-path lookup first, only falling back to a title lookup if that failed. This let an unrelated route path silently shadow a real title match, resolving the link to the wrong page with Broken staying false. resolveWikiLinkTargets now always tries the title lookup first for every target, including slash-containing ones; route-path lookup is only attempted as a fallback when there are zero title matches, which still supports [[some/nested/page]]-style route hints. An ambiguous title match (N>1) is treated the same as the plain-title case (broken), for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…kilinks
A [[Title]] wikilink whose title contains a "/" (e.g. [[TCP/IP]]) tried a route-path lookup first, only falling back to a title lookup if that failed. This let an unrelated route path silently shadow a real title match, resolving the link to the wrong page with Broken staying false.
resolveWikiLinkTargets now always tries the title lookup first for every target, including slash-containing ones; route-path lookup is only attempted as a fallback when there are zero title matches, which still supports [[some/nested/page]]-style route hints. An ambiguous title match (N>1) is treated the same as the plain-title case (broken), for consistency.